Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set compat upper bound for ResumableFunctions #87

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

ba2tro
Copy link
Member

@ba2tro ba2tro commented Jan 5, 2024

Due to bugs in macro parsing with the current release of ResumableFunctions, setting an upper bound on the compat until the issues are resolved

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f95a2e8) 74.98% compared to head (3b6a314) 82.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   74.98%   82.55%   +7.57%     
==========================================
  Files          37       36       -1     
  Lines        1399     1261     -138     
==========================================
- Hits         1049     1041       -8     
+ Misses        350      220     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ba2tro ba2tro merged commit fdcbe41 into QuantumSavory:master Jan 5, 2024
8 of 10 checks passed
@Krastanov
Copy link
Member

Could you file issues about these bugs, so we can keep track of things? We would want to easily remove these restrictions in the near future. Right now I am not sure we actually know what the issue is.

@ba2tro ba2tro mentioned this pull request Jan 12, 2024
@ba2tro ba2tro deleted the upperbound branch February 27, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants