Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot adjust #17

Merged
merged 10 commits into from
Dec 19, 2024
Merged

Plot adjust #17

merged 10 commits into from
Dec 19, 2024

Conversation

Benzillaist
Copy link
Contributor

  • Removed Shor syndrome circuit image generation as they all crashed the drawing engine (except for perfect 5). Code has been commented out for the time being, will be commented in once QASM code generation has been implemented
  • Fixed some errors with plotting in CairoMakie where 'linestyle' and 'marker' weren't defined
  • Adjusted plot size to make lines clearly visible
  • Adjusted plot text size to to be more visible
  • Changed names of loaded files in markdown template so correct image loads

In future PRs:

  • Downloadable QASM files for each example
  • Create a separate markdown template for codes larger than 10 qubits (they're missing the ecirc and scirc, currently displaying missing image icon)
  • Addressing some of the other issues in Github

- Removed Shor syndrome circuit image generation as they all crashed the drawing engine (except for perfect 5). Code has been commented out for the time being, will be commented in once QASM code generation has been implemented
- Fixed some errors with plotting in CairoMakie where 'linestyle' and 'marker' weren't defined
- Adjusted plot size to make lines clearly visible
- Adjusted plot text size to to be more visible
- Changed names of loaded files in markdown template so correct image loads
@Benzillaist Benzillaist marked this pull request as ready for review November 26, 2024 08:34
@Benzillaist
Copy link
Contributor Author

I made a few changes to help with generating the images, but there are still a good few changes I'd like to make image-wise, but that might wait for later until other parts of the website are more up-to-date

@Krastanov
Copy link
Member

This looks great! Could you please remove all of the "autogenerated" changes (the ones in the codes folder).

This project is not yet well-organized, but if it was, this whole "generated" folder will not be kept in this repo's master branch (similarly to how website content on github is usually in gh-pages). It is generally bad style to have "build artifacts"
in version control. Until this is properly fixed, I am still trying to just keep changes to the build artifacts in separate commits, out of the PRs that undergo code review. This makes tracking the changes in this project a bit more manageable.

@Krastanov
Copy link
Member

Another suggestion: the TODO you have added, feel free to keep them in, but it would be a good idea to post them as issues on the issue tracker as well (if they do not exist yet)

@Benzillaist
Copy link
Contributor Author

Thanks! I'll be sure to leave out build changes in the future! I'll also go through and add the TODOs to the listed issues :)

@Benzillaist Benzillaist marked this pull request as draft November 27, 2024 19:21
@Benzillaist Benzillaist marked this pull request as ready for review November 27, 2024 19:21
@Krastanov
Copy link
Member

thank you, this was very helpful! I made a few small changes you can see in the commits above. I will push the new build artifacts shortly

@Krastanov Krastanov merged commit aa826b5 into QuantumSavory:master Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants