[Oxygen] Fixes crash when closing window.

This is proper fix for #838
QupZilla · May 13, 2013 · c16b361 · c16b361
1 parent 608197a
commit c16b361
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,7 @@
+Version 1.4.4
+    * not released yet
+    * fixed: crash with Oxygen theme when closing windows with tabs on top
+
 Version 1.4.3
     * released 9 May 2013
     * fixed: crash upon closing private browsing window

diff --git a/src/lib/webview/webtab.cpp b/src/lib/webview/webtab.cpp
@@ -384,8 +384,8 @@ void WebTab::disconnectObjects()
 
 WebTab::~WebTab()
 {
-    // #838 !mApp->isClosing() fixes crash on app close with Oxygen theme
-    if (m_navigationContainer && qzSettings->tabsOnTop && !mApp->isClosing()) {
+    // #838 !p_QupZilla->isClosing() fixes crash on app close with Oxygen theme
+    if (m_navigationContainer && qzSettings->tabsOnTop && !p_QupZilla->isClosing()) {
         m_layout->removeWidget(m_navigationContainer);
 
         // Needed to prevent flickering when closing tabs