feat: allow to specify a scope for text/partytown scripts #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaa123eee
commented
Sep 11, 2024
| @@ -96,7 +96,7 @@ export function snippet( | |||
| doc.querySelector(config!.sandboxParent || 'body')!.appendChild(sandbox); | |||
| } | |||
|
|
|||
| function fallback(i?: number, script?: HTMLScriptElement) { | |||
| function fallback() { | |||
There was a problem hiding this comment.
parameters were never passed to the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
We have our custom "text/partytown" scripts added to the document which meant to be executed only in the worker scope.
If the fallback happens, we have to check an execution scope to avoid errors,
like
typeof WorkerGlobalScope === 'undefined'I suggest more elegant way of settling a scope for a script
Checklist: