Missing requirements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlvaroCavalcante
commented
Aug 20, 2020
AlvaroCavalcante
commented
- Removed unused libraries
- Adding versions in requirements.txt
- Adding the missing libraries to install automatically
- Updated setup version
added missing requirements on install the package
Closed
|
@R1j1t , you can improve your code if you run To more information, access: https://flake8.pycqa.org/en/latest/ |
Closed
R1j1t
reviewed
Aug 21, 2020
requirements.txt
Outdated
Comment on lines
1
to
6
| Flask==1.1.1 | ||
| spacy==2.3.2 | ||
| editdistance==0.5.3 | ||
| pytest==6.0.1 | ||
| torch==1.6.0 | ||
| transformers==3.0.2 |
There was a problem hiding this comment.
I dont think it is a good idea to specify the exact version, so can you change it back?
|
Apart from the requirements.txt everything else looks good. I will merge it once you make the changes |
Closed
|
@Lucs1590 it is a good suggestion. I thought about adding both flake8 and black when I started the project. While I was developing the features I found correcting flake8 warnings was slowing the coding process, so I stuck only with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.