Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use expect_setequal() may fit better #363

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

shrektan
Copy link
Contributor

@shrektan shrektan commented Jan 8, 2021

I think using expect_setequal() may be better for these testing cases.

@randy3k
Copy link
Member

randy3k commented Jan 8, 2021

Agree.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit 297ab17 into REditorSupport:master Jan 12, 2021
@shrektan shrektan deleted the use-setequal branch January 12, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants