Respect document languageId
#511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@randy3k @inventionate I'm not sure about the behavior of editors other than vscode. Do they provide |
|
LGTM. Thanks for working on it. Sublime Text's LSP does respect ``languageId` afaict. |
randy3k
approved these changes
Jan 7, 2022
|
Sorry for the late response. Yes the built-in LSP client of Neovim provides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes REditorSupport/vscode-R#930
Closes #510
This PR supports the unused field
languageIdofTextDocumentItemso that any file withlanguageId == 'rmd'is treated as rmd file. IflanguageIdis not provided on document open, then it will fallback to using file extension to determine if it is rmd.