feat: support sbom list as request body #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieshenzh
force-pushed
the
api-sbom-list
branch
2 times, most recently
from
22d793d
to
1e03a21
Compare
|
Pending merging of the api changes to pass CI compilation: RHEcosystemAppEng/exhort-api-spec#13 |
ruromero
requested changes
Feb 21, 2024
There was a problem hiding this comment.
This solution doesn't conform with the OpenApi spec where the /analysis endpoint returns an AnalysisReport object. See https://github.com/RHEcosystemAppEng/exhort-api-spec/blob/main/api/v4/openapi.yaml#L53
I recommend creating a new endpoint /batchanalysis for that purpose. With that you won't need to add the list parameter to the MediaType
xieshenzh
force-pushed
the
api-sbom-list
branch
from
1e03a21
to
4cef6dc
Compare
ruromero
requested changes
Feb 27, 2024
src/main/java/com/redhat/exhort/integration/backend/ExhortIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/backend/ExhortIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/backend/ExhortIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/root/RootTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/root/RootTransformer.java
Outdated
Show resolved
Hide resolved
xieshenzh
force-pushed
the
api-sbom-list
branch
8 times, most recently
from
3239ff2
to
7149dc7
Compare
ruromero
approved these changes
Mar 5, 2024
src/main/java/com/redhat/exhort/integration/backend/ExhortIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/exhort/integration/providers/ProviderResponseHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Olga Lavtar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support reporting package vulnerabilities in base images:
batch-analysisto handle the requests with a dictionary of sboms as payloadJira: https://issues.redhat.com/browse/APPENG-2250 and https://issues.redhat.com/browse/APPENG-2251