Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core SSH keys #23

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Update core SSH keys #23

merged 11 commits into from
Jun 7, 2023

Conversation

loganmc10
Copy link
Contributor

@loganmc10 loganmc10 commented Jun 5, 2023 •
edited
Loading

Fixes #8

Workflow:

  • this one is fairly simple, it just creates a MachineConfig for the new SSH authorized keys. The new keys get appended to whatever is there currently (the existing key isn't deleted)
  • because the MachineConfig is owned by the CR, when the CR is deleted, the MachineConfig is deleted as well

As a side note, the MachineConfig doesn't cause a reboot

@loganmc10 loganmc10 self-assigned this Jun 5, 2023
@loganmc10 loganmc10 marked this pull request as draft June 5, 2023 21:28
@loganmc10 loganmc10 requested a review from danielchg June 6, 2023 02:49
@loganmc10 loganmc10 marked this pull request as ready for review June 6, 2023 02:49
@loganmc10
Copy link
Contributor Author

@danielchg this one is ready for review

@loganmc10 loganmc10 force-pushed the ssh branch 3 times, most recently from abe58bf to 7af7afd Compare June 7, 2023 13:42
danielchg
danielchg approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@danielchg danielchg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielchg danielchg merged commit c674c10 into main Jun 7, 2023
@danielchg danielchg deleted the ssh branch June 7, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielchg danielchg danielchg approved these changes

Assignees

@loganmc10 loganmc10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 'core' user SSH key
2 participants
@loganmc10 @danielchg