Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC permissions using kubebuilder comments #35

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Add RBAC permissions using kubebuilder comments #35

merged 2 commits into from
Jun 13, 2023

Conversation

loganmc10
Copy link
Contributor

@loganmc10 loganmc10 commented Jun 8, 2023

Fixes #28

Adding a comment like:

//+kubebuilder:rbac:groups="",resources=secrets,verbs=watch

and then running make manifests updates the operator's RBAC file with the correct permissions. I'm pretty sure this is how it's meant to be done, this way you can define the RBAC permissions in the same file that they are used in

@loganmc10 loganmc10 self-assigned this Jun 8, 2023
@loganmc10 loganmc10 marked this pull request as draft June 8, 2023 22:49
@loganmc10 loganmc10 force-pushed the rbac branch 3 times, most recently from 8618a6a to 673d4af Compare June 10, 2023 11:41
@loganmc10 loganmc10 requested a review from danielchg June 10, 2023 11:42
@loganmc10 loganmc10 marked this pull request as ready for review June 10, 2023 11:42
@loganmc10 loganmc10 merged commit a16bdf4 into main Jun 13, 2023
@loganmc10 loganmc10 deleted the rbac branch June 13, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test and fix RBAC
1 participant