including additional stm32c0 cpu and board targets #20939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparker324
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
aabadie and
vincent-d
as code owners
github-actions
bot
added
Platform: ARM
jparker324
requested review from
miri64 and
MichelRottleuthner
as code owners
github-actions
bot
added
Area: tests
jparker324
force-pushed
the
stm32c0-additions
branch
2 times, most recently
from
b030b16
to
9fbb04a
Compare
jparker324
force-pushed
the
stm32c0-additions
branch
from
b58124d
to
e340c07
Compare
|
Very nice! Thank you! |
jparker324
force-pushed
the
stm32c0-additions
branch
from
e340c07
to
5deb18e
Compare
@benpicco updated commits 👍 |
benpicco
reviewed
Nov 13, 2024
There was a problem hiding this comment.
sorry to nitpick, but please further split up the commits, one per board. And then one for the CPU, so you have
cpu/stm32: add new STM32C0 linesboards/nucleo-c071rb: add supportboards/stm32c0116-dk: initial supportboards/stm32c0116-disco: initial supporttreewide: add new stm32c0 boards to Makefile.ci
Do you have some test output?
The periph tests would be most interesting (tests/periph/spi, tests/periph/i2c, tests/periph/uart), and since this line had some issues there in the past, I'd check especially tests/periph/rtc and tests/periph/rtt
| source [find interface/stlink-v2.cfg] | ||
| source [find target/stm32c0x.cfg] | ||
|
|
||
| #reset_config srst_only |
Comment on lines
+5
to
+7
| #reset_config srst_only | ||
|
|
||
| #$_TARGETNAME configure -rtos auto |
| @@ -103,9 +103,6 @@ static const uart_conf_t uart_config[] = { | |||
| * For Nucleo-C031C6 this information is in board manual, | |||
| * Table 11, page 20. | |||
| * | |||
| * STM32C031C6 do not have internal channel for VBAT, more details provided | |||
| * in the MCU datasheet - section 3.14, page 20. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding updated
STM32C0targets per https://www.st.com/en/microcontrollers-microprocessors/stm32c0x1.htmlSupported
cputargets now includeSTM32C011,STM32C031,STM32C051,STM32C071,STM32C091, andSTM32C092.Added
boardtargetsstm32c0116-dkandstm32c0316-dk, further resolving issue #19210, andnucleo-c071rb(https://www.st.com/en/evaluation-tools/nucleo-c071rb.html).General reference issue #19264