Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old network stack #3334

Merged
merged 30 commits into from
Aug 6, 2015
Merged

remove old network stack #3334

merged 30 commits into from
Aug 6, 2015

Conversation

kaspar030
Copy link
Contributor

This is my WIP branch for removing the legacy stack. Feel free to PR more removals against this, or just ignore.

@kaspar030 kaspar030 added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Impact: major The PR changes a significant part of the code base. It should be reviewed carefully labels Jul 7, 2015
@kaspar030 kaspar030 mentioned this pull request Jul 15, 2015
Closed
12 tasks
@kaspar030
Copy link
Contributor Author

  • removed some more stuff
  • rebased

@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 5, 2015
@OlegHahm
Copy link
Member

OlegHahm commented Aug 5, 2015

NACK - I'm against removing ccn-lite and cc2420 completely without having a commitment of someone to re-import this within the next three months.

@kaspar030
Copy link
Contributor Author

@OlegHahm So you're against what we decided three weeks ago (removal of the old network stack)?

The code is not gone. It is just kicked out of master. The old functionality will still be there for all eternity (good luck, github!), nicely tagged, for everyone interested in using today's RIOT together with cc2420 edit and ccn-lite.

@OlegHahm
Copy link
Member

OlegHahm commented Aug 5, 2015

I'm against removing ccn-lite and drivers that are mostly unrelated to the old or the new network stack without any commitment of re-import them soonish.

The code is not gone. It is just kicked out of master.

Which is basically the same thing. No-one will use invisible, unmaintained code.

@kaspar030
Copy link
Contributor Author

I'm against removing ccn-lite and drivers that are mostly unrelated to the old or the new network stack without any commitment of re-import them soonish.

I'd prefer keeping them in, too, but it is not that easy. Guys, anyone keen on nitpicking all the coding convention breaches and other problems of an evolving RIOT, expressing feelings of "rather not", please let's not make the burden of supporting legacy stuff so big that RIOT will just stagnate feature wise.

The old network code is legacy. We cannot support it.

@OlegHahm
Copy link
Member

OlegHahm commented Aug 5, 2015

I don't see any burden with this particular code, seems more like FUD statement.

@kaspar030
Copy link
Contributor Author

I don't see any burden with this particular code, seems more like FUD statement.

cc2420 uses the old transceiver interface...

@cgundogan
Copy link
Member

IMHO we could use #3417 to assign certain features that will be lost during the transition to certain people. This way, features won't be lost forever and we will have something to use as a lookup in case we need a reminder. However, this still requires that we check on this list regularly in order to not lose the goal out of sight

@kaspar030
Copy link
Contributor Author

Travis is happy for everything but tests/coap on avr8, which is being blacklisted in #3562.
So I'd say, please review!

@kaspar030 kaspar030 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Aug 5, 2015
@kaspar030
Copy link
Contributor Author

  • rebased

@cgundogan
Copy link
Member

+13 −32,369 👍

@haukepetersen
Copy link
Contributor

sys/Makefile.include: remove net_help entry, ieee802154 entry,

@kaspar030
Copy link
Contributor Author

  • rebased

@haukepetersen haukepetersen mentioned this pull request Aug 5, 2015
Merged
@kaspar030
Copy link
Contributor Author

(@OlegHahm's issues sorted out while having lunch)

@haukepetersen haukepetersen mentioned this pull request Aug 5, 2015
Closed
@kaspar030
Copy link
Contributor Author

Travis is happy. Could you guys please take another look? @authmillenon? @haukepetersen?

kaspar030 and others added 14 commits August 6, 2015 12:13
@kaspar030
boards: avsextrem: remove obsolete cc1100 code
9db612c
@kaspar030
sys: net: remove AODVv2
00a44c9 
(will be upgraded to gnrc soon)
@kaspar030
sys: make: remove obsolete network Makefile includes
8fd237d
@kaspar030
make: remove obsolete legacy network stack dependencies
c5dfa44
@kaspar030
sys: net: remove ccnlite-ext-appserver
a5642ef
@kaspar030
sys: make: remove obsolete ieee802154
2633352
@haukepetersen @kaspar030
removed deps to transceiver and sys/net/include
359edca 
for
    - avsextrem
    - redbee-econotag
    - spark-core
    - telosb
    - z1
@kaspar030
remove defaulttransceiver, cc110x, cc2420 traces
bbf64e8
@haukepetersen @kaspar030
boards: remove feature 'transceiver'
bff1d7e
@kaspar030
doc: remove obsolete transceiver documentation
1733d4a
@haukepetersen @kaspar030
cpu: remove transceiver defines from cpu_conf files
75472ed
@kaspar030
examples: default: remove obsolete networking docs
75bc87c
@kaspar030
boards: avsextrem redbee-econotag spark-core telosb z1: fix includes
57d7e62
@kaspar030
remove temporarily dropped features from README.md
f9ee9da
@kaspar030
Copy link
Contributor Author

  • squashed some commits

@kaspar030
Copy link
Contributor Author

I'd say, merge...

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Aug 6, 2015
@OlegHahm
Copy link
Member

OlegHahm commented Aug 6, 2015

oops, accidentally hit the Travis restart button...

@PeterKietzmann
Copy link
Member

It was green, I saw it :-)

@PeterKietzmann
Copy link
Member

We could try to formulate this: Is anyone against merging this PR? @authmillenon ?

@haukepetersen
Copy link
Contributor

go ahead! It might make sense to squash a little bit, but I do not really have an opinion on this...

@miri64
Copy link
Member

miri64 commented Aug 6, 2015

If everything is green: go ahead an merge. I'm with @kaspar030: the only way to test it is to compile the remaining apps. If you want and in-depth look at the list of removed files you have to wait a little: the mobile interface complains: "can't show full diff, too many files changed" ^^

OlegHahm added a commit that referenced this pull request Aug 6, 2015
@OlegHahm
Merge pull request #3334 from kaspar030/remove_old_net
f90032f 
remove old network stack
@OlegHahm OlegHahm merged commit f90032f into RIOT-OS:master Aug 6, 2015
@haukepetersen
Copy link
Contributor

YEAH!

@OlegHahm
Copy link
Member

OlegHahm commented Aug 6, 2015

Update the web page accordingly. Let me know if I missed something.

@kaspar030
Copy link
Contributor Author

YES!

@kaspar030 kaspar030 deleted the remove_old_net branch August 6, 2015 13:35
@miri64
Copy link
Member

miri64 commented Aug 6, 2015

Bittersweet (since it removed s a lot of old code of mine) yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: major The PR changes a significant part of the code base. It should be reviewed carefully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaspar030 @OlegHahm @cgundogan @haukepetersen @PeterKietzmann @miri64