drivers/cc2420: initial netdev port for cc2420 #3915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides a prototype of a cc2420 driver implementing netdev interface. It is currently not fully tested because of issues with the msp430 platform and thus marked as WIP.
thomaseichinger
added
State: WIP
12 tasks
| USEMODULE += xtimer | ||
| USEMODULE += cc2420 | ||
| USEMODULE += gnrc_nomac | ||
| endif |
|
I just did a scan through the driver code (though it is still WIP). Don't mind the style comments. Besides them, I could not see any obvious problems, especially once regarding the state machine... |
| { | ||
| uint16_t state = 0; | ||
| state = cc2420_reg_read(dev, CC2420_REG_FSMSTATE); | ||
| return dev->state; |
There was a problem hiding this comment.
Shouldn't you return the state variable, instead of the dev->state field? Or do something like:
dev->state = state;
return dev->state;
It seems it would make much more sense.
Plus, I think this one of the problems that make Travis static tests fail in the first place...
|
@thomaseichinger Ping. A kind reminder for rebase. |
|
@thomaseichinger, ping |
|
I guess we have to postpone. |
|
I guess this can be closed with #5314 merged, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides a prototype of a cc2420 driver implementing netdev interface.
It is currently not fully tested because of issues with the msp430 platform and
thus marked as WIP at self assigned for now.