Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 19 #118

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Upgrade to Angular 19 #118

wants to merge 1 commit into from

Conversation

xylo04
Copy link
Member

@xylo04 xylo04 commented Nov 30, 2024

No description provided.

@xylo04
Copy link
Member Author

xylo04 commented Nov 30, 2024

Stuck on FirebaseError: Expected type '_Query', but it was: a custom _DocumentReference object similar to angular/angularfire#3581 (comment), and their overrides workaround is not working for me.

@xylo04 xylo04 marked this pull request as draft November 30, 2024 17:59
@StefanKern
Copy link

@xylo04 I took a look into the issue, and found out, that rxfire causes firebase@10... to be installed. If I add the additonal overwrite:


  "overrides": {
    "@angular/fire": {
      "@angular/core": "$@angular/core",
      "@angular/common": "$@angular/common",
      "@angular/platform-browser": "$@angular/platform-browser",
      "@angular/platform-browser-dynamic": "$@angular/platform-browser-dynamic"
    },
    "rxfire": {
      "firebase": "^11.0.0"
    }
  },

it works fine:

image

I do not know for what https://www.npmjs.com/package/rxfire is used, and why it is needed, but it did not recieve any updates for the past year... and I just saw that there is a comment, that that missing upgrade is preventing the angular fire migration...

So the issue is already noticed, but it was not documented anywhere. Still leaving that comment, cause it might help others who are also wondering what the upgrade is not comming.

This are the working package.json and package-lock.json for the 'web' project
package-lock.json
package.json

@xylo04
Copy link
Member Author

xylo04 commented Dec 11, 2024

Wow, thanks for the info, @StefanKern!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants