Clean up trailing whitespace so as to reduce noise in #246. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangupta
approved these changes
Nov 8, 2017
zhaozhangjian
added a commit
to zhaozhangjian/HIP
that referenced
this pull request
Jun 24, 2021
Synchronize memory copy API - hipMemcpy() issues h2d_copy() and d2h_copy(), which use userptr as a staging buffer. For the memory copy between this staging buffer and device memory, device agent is currently passed as the argument for both the src and dst agents, which means D2D copy to ROCR and is executed by blit kernel. Blit kernel uses the cache of userptr (if hit) on device, which may cause memory coherency problem if the userptr on host is changed and the device is blind to the change. This change passes host agent and device agent as arguments in d2h_copy() and h2d_copy(), which makes this memory copy be executed on SDMA in ROCR. SDMA ignores the cache of userptr on device and guarantees memory coherency. Signed-off-by: Zhangjian Zhao <[email protected]> Change-Id: I7441530e515a2ac8d299f55b89d54fbaccfa986f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.