[BUGFix] Reorder GetSmemSize Related API #1683
Open
+42
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiWang1999
requested review from
junliume,
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer and
bartekxk
as code owners
aosewski
approved these changes
Nov 25, 2024
aosewski
requested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves significant changes to the
struct GemmPipelineAGmemBGmemCRegV1DefaultPolicyin the fileinclude/ck_tile/ops/gemm/pipeline/gemm_pipeline_agmem_bgmem_creg_v1_default_policy.hpp. The changes mainly focus on the reintroduction of several methods:GetSmemSizeA: Calculates the shared memory size for matrix A.GetSmemSizeB: Calculates the shared memory size for matrix B.GetSmemSize: Computes the total shared memory size by summing the sizes of matrices A and B.GetSmemPackA: Determines the packing size for matrix A based on the vector load size.GetSmemPackB: Determines the packing size for matrix B based on the vector load size.Currently they're put only when the 3d+pad descriptor is enabled.