Fix errors in python tests #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SundarRajan28
commented
Oct 17, 2024
SundarRajan28
commented
- Added the missed shardingInfo argument in the pybind call for video and external source reader
- Added absolute path for AMDTinyDataset in decoder.py example
rrawther
previously approved these changes
Oct 17, 2024
There was a problem hiding this comment.
@SundarRajan28: Please make sure no other tests are broken in rocAL with last_batch_policy update
LakshmiKumar23
previously approved these changes
Oct 28, 2024
|
@SundarRajan28 : Can you please resolve conflicts for this PR |
SundarRajan28
dismissed stale reviews from LakshmiKumar23 and rrawther
via
3c0ff50
|
@rrawther Resolved merge conflicts |
LakshmiKumar23
approved these changes
Oct 28, 2024
rrawther
approved these changes
Oct 28, 2024
LakshmiKumar23
added a commit
to LakshmiKumar23/rocAL
that referenced
this pull request
Nov 1, 2024
* Adding sharding info changes for readers * Adding absolute path for images dataset --------- Co-authored-by: Lakshmi Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.