Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rocprof-sys-sample cannot get GPU related tracing #87

Open
wants to merge 1 commit into
base: release/rocm-rel-6.3
Choose a base branch
from

Conversation

adjordje-amd
Copy link

@adjordje-amd adjordje-amd commented Jan 20, 2025

The _librccl lifespan has been changed to static, so that the library handler remains valid during later calls and avoid undefined behavior.

@adjordje-amd adjordje-amd force-pushed the fix/smi-stats-missing branch 5 times, most recently from f509344 to e0cfaf7 Compare January 20, 2025 15:28
@adjordje-amd adjordje-amd force-pushed the fix/smi-stats-missing branch from e0cfaf7 to e084087 Compare January 20, 2025 15:36
@dgaliffiAMD
Copy link
Collaborator

Thanks, Aleks.
This does fix the original issue for the transpose example; rocprof-sys-sample --PTDH -I all -- ./transpose now includes "rocm-smi" samples. However, it seems to have introduced a new type failure for certain workloads. For example, when I run rocprof-sys-sample -PTDH -I all -v 2 -- ls -al, the trace fails to exit. We get stuck while tearing down:

[rocprof-sys][597260] Removing temporary file '/tmp/rocprofsys-ls-output/281783/sampling-597260.dat'...
[rocprof-sys][597260][0][rocprofsys_finalize] Finalized: 0.045335 sec wall_clock,    2.304 MB peak_rss,    2.359 MB page_rss, 0.010000 sec cpu_clock,   22.0 % cpu_util

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants