Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug created by dragging token from library to map #633

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

Merudo
Copy link
Member

@Merudo Merudo commented Aug 28, 2019


This change is Reviewable

- Fix token having duplicated ids if a cut was followed by dragging token to map then a paste (induced by RPTools#625)
- Fix dragging token from library to map not ungraying the "Paste" option (fully completes RPTools#630)
@Merudo
Copy link
Member Author

Merudo commented Aug 28, 2019

Did not fully finish the job on #621 and #624 because I thought the "automatically copy newly dragged to map token" behavior was going away.

This PR completes the two issues.

Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus Phergus merged commit 453e94c into RPTools:develop Aug 28, 2019
@Merudo Merudo deleted the dragTokenToMap branch August 28, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants