-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wrong nb of parameters error messages to display function name #641
Conversation
Before RPTools/parser#3 gets merged, you can test out this branch by getting it, then changing in
to
|
e529298
to
a823be9
Compare
- Change wrong number of parameters error messages to always display name of function - Builds on RPTools/parser#3 to work - Close RPTools#629
@cwisniew approved the parser merge, so this works fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor concern about the use of "master-SNAPSHOT" in the build.gradle file as we haven't done that in the past. It has been nice to just see at a glance what version of a library was being pulled in.
Reviewed 6 of 6 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
I'll ask @cwisniew to release a new version of the parser, so it will be cleaner. |
It may be that the way you did it is more flexible for future builds. @cwisniew ? @JamzTheMan ? |
I created a 1.5.4 release and is now available, give it a try. @Phergus All we need to do is a GitHub "Release" off master for Parser. JitPack does the rest and you can vew them here: https://jitpack.io/#RPTools/parser/1.5.4 It's actually pretty easy. There's no CI right now for Parser. And ya, we should only use MASTER--Snapshot for testing. Since @cwisniew approved it I assume we are all good to go. |
Roger that. Merging on it then. |
Oh oh, um, sorry, guess I wasn't clear. @Merudo (or anyone) still need to update the gradle file here to point to the parser-1.5.4 release vs master snapshot... I only did a "Parser" release which created a new Parser release to be used... Another PR will need to be created to update the gradle.build in MapTool |
PR #659 changes the parser to 1.5.4 |
My bad. I misread your post and didn't catch the "for testing". |
[input()]
Old error message:
New error message:
This change is