Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update estraverse #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

RicardoGeek
Copy link

I'm updating the estraverse dependency to deprecate jade, use the latest of graceful-fs and minimatch.
I think it won't break anything.

@RReverser
Copy link
Owner

Thanks for the PR, but I'm a bit confused about this:

I'm updating the estraverse dependency to deprecate jade, use the latest of graceful-fs and minimatch.

Judging from the diff, you updated only mocha, but not estraverse (which is used here only as a peer dependency with * to allow usage with any version).

@RicardoGeek
Copy link
Author

Hi,
I'm really sorry, I didn't put a lot of thinking on my commit messages. What I meant is that I updated this module to use a new version of mocha in order to avoid the following deprecation messages while building:

npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

With the lines I changed they are all gone, and the travisCI checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants