feat: add mastodon related config details #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankLi123
suggested changes
Oct 10, 2024
| IsRequired: true, | ||
| Type: StringType, | ||
| Value: "activitypub_events", | ||
| Description: "The Kafka topic to publish the ActivityPub data to. If not provided, the data will be published to the default topic", |
There was a problem hiding this comment.
"The Kafka topic to which the ActivityPub data will be published. By default, the data will be sent to this topic on the Kafka broker running on the Mastodon instance."
| @@ -217,8 +226,10 @@ func customWorkerConfig(worker worker.Worker, network network.Source, parameters | |||
| return config | |||
| } | |||
|
|
|||
| func getEndpointConfig() Endpoint { | |||
| return Endpoint{ | |||
| const mastodonInstanceDescription = "A Mastodon instance is required. Please follow <a href=\"https://github.com/RSS3-Network/Mastodon-Instance-Kit\" target=\"_blank\">the guide</a> to deploy your own instance. Once deployed, set the endpoint of your Mastodon instance here." | |||
There was a problem hiding this comment.
"A Mastodon instance is required. Please follow <a href="https://github.com/RSS3-Network/Mastodon-Instance-Kit\" target="_blank">the guide to either deploy a new Mastodon instance or modify an existing Mastodon instance. After completing either option, enter your Mastodon endpoint (format: your_instance_ip:9092) here."
| IsRequired: true, | ||
| Type: StringType, | ||
| Value: "activitypub_events", | ||
| Description: "The Kafka topic to publish the ActivityPub data to. If not provided, the data will be published to the default topic", |
There was a problem hiding this comment.
could revise this as suggested above.
kallydev
pushed a commit
that referenced
this pull request
Oct 12, 2024
feat: add mastodon related config details (#556) feat: change rss to object and add default network endpoint url (#557) feat: add title and key in config detail (#558) chore: reorder the worker configs (#559) fix: change mastodon endpoint type to string (#560) feat: add default value and type for worker endpoint config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add mastodon related config details
Checklist
Does this PR introduce a breaking change?