Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dp_start value in solar collector #1452

Closed
FWuellhorst opened this issue Aug 14, 2023 · 0 comments · Fixed by #1453
Closed

Fix dp_start value in solar collector #1452

FWuellhorst opened this issue Aug 14, 2023 · 0 comments · Fixed by #1453
Assignees
@FWuellhorst

Comments

@FWuellhorst
Copy link
Contributor

Describe the bug
The default value of dp_start is incorrect.

It is stated as

dp_start=pressureDropCoeff*(m_flow_start *
      Medium.density(Medium.setState_pTX(
                       p_start,
                       T_start,
                       Medium.reference_X)))^2)

but should be

dp_start=pressureDropCoeff*(m_flow_start /
      Medium.density(Medium.setState_pTX(
                       p_start,
                       T_start,
                       Medium.reference_X)))^2)

as dp = a*(m_flow/rho) ^2.
@FWuellhorst FWuellhorst self-assigned this Aug 14, 2023
FWuellhorst added a commit that referenced this issue Aug 14, 2023
@FWuellhorst
Fix division error #1452
14e90c1
@FWuellhorst FWuellhorst linked a pull request Aug 14, 2023 that will close this issue
Fix division error #1452 #1453
Merged
@FWuellhorst FWuellhorst mentioned this issue Aug 14, 2023
Merged
TobiasSpratte added a commit that referenced this issue Sep 19, 2023
@TobiasSpratte
Merge pull request #1453 from RWTH-EBC/1452-fix-dp_start-value-in-sol…
ae5066b 
…ar-collector

Fix division error #1452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FWuellhorst FWuellhorst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix division error #1452 RWTH-EBC/AixLib
1 participant
@FWuellhorst