Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing each #1342 #1353

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

FWuellhorst
Copy link
Contributor

This PR already enables the simulation of ThermalZone in OpenModelica. At a first glance, the results are almost the same.
However, we should keep #1349 open as further issues exist. I will update the OM error logs based on this PR.

Closes #1342.

Copy link
Contributor

@larissakuehn larissakuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks finde

@FWuellhorst FWuellhorst merged commit 336e95f into development Oct 7, 2022
@FWuellhorst FWuellhorst deleted the Issue1342_wrongZoneParamUnit branch October 7, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong units in zoneRecord
2 participants