Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1349 reducedorder fails in openmodelica #1377

Conversation

hannah-kruetzfeldt
Copy link
Contributor

Solving 1349, all examples except for MultizoneEquipped and MultizoneMoistAirCO2Equipped simulate in OM. This is related to Issue1344 missing transition functions in AHU.

Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice work! Please revert one file.

Comment on lines 112 to 117
block StartState
outer output Modelica.Units.SI.HeatFlowRate Q_dot_C;
outer output Modelica.Units.SI.HeatFlowRate Q_dot_H;
initial equation
Q_dot_C = 1e-3;
Q_dot_H = 1e-3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either I pushed local changes or you merged the branch for the AHU in here. Please revert this file, as my current changes may be wrong!

Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!!

@hannah-kruetzfeldt hannah-kruetzfeldt merged commit 5822534 into openModelicaProject Oct 13, 2022
@hannah-kruetzfeldt hannah-kruetzfeldt deleted the Issue1349_reducedorder_fails_in_openmodelica branch October 13, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants