Issue1354 polynomial based pump records #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cients, add documentation
30/1-12 50/1-10 modified characteristic curve 25/0.5-12
…hub.com/RWTH-EBC/AixLib into issue1354_Polynomial_Based_Pump_Records
…hub.com/RWTH-EBC/AixLib into issue1354_Polynomial_Based_Pump_Records
…hub.com/RWTH-EBC/AixLib into issue1354_Polynomial_Based_Pump_Records
…TML_issue1354_Polynomial_Based_Pump_Records
…ial_Based_Pump_Records Corrected HTML Code in branch correct_HTML_issue1354_Polynomial_Based_Pump_Records
FelixStege
approved these changes
Oct 25, 2023
| @@ -0,0 +1,138 @@ | |||
| within AixLib.DataBase.Pumps.PumpPolynomialBased; | |||
| record Pump_DN25_H05_12 "Pump with head 0.5 to 12,4m and 12,4m^3/h volume flow (25/0.5-12 PN)" | |||
There was a problem hiding this comment.
Is it 12,4 m^3/h? Looking at the data, it looks more like 11,5 m^3/h
| @@ -0,0 +1,144 @@ | |||
| within AixLib.DataBase.Pumps.PumpPolynomialBased; | |||
| record Pump_DN30_H1_12 "Pump with head 1 to 11m and 10,7m^3/h volume flow (Wilo Stratos 30/1-12)" | |||
There was a problem hiding this comment.
Same here, are these values (head and volume flow) correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add polynominal based pump records based on characteristic curves:
25/0.5-12 PN 10 maximum volume flow 12.0 m^3/h
50/0.5-16 PN 6/10 maximum volume flow 53.0 m^3/h