1407 add swimming pool model #1414
Conversation
…ded documentation #1407
…ool-model' into 1407-add-swimming-pool-model
…to 1407-add-swimming-pool-model
There was a problem hiding this comment.
- Why do you need the OndoorSwimmingPoolDummy record? If it's not needed. you can delete it.
- the BaseRecord contrains names with camelCase and also some names with _ (e.g. use_HRS). Please use the naming convention: naming scheme
- The WallDummy is not used as well? Please delete if not needed.
- I suggest to delete the package: TypesOfIndoorSwimmingPools and move the record one level up (similar to other record packages), or move the BaseRecord to the same folger
- rename the record IndoorSwimmingPoolBaseRecord to IndoorSwimmingPoolBaseDataDefinition
- Rename package fluid.pool to fluid.pools (analog to movers, heatpumps, etc.)
- Add a short description for the parameter WallBaseDataDefinition in the model HeatTransferCondution
- General remark: check if all parameters that should't be changed are 'final'
- IndoorSwimmingPool: add a parameter for the added water temperature in the component 'bou'
- IndoorSwimmingPool: propagate the parameter massDynamics
- Add a simulate_and_plot script for the two examples
- fix the initial conditions in the example indoorSwimmingPoolExternalHeatingSystem
- Add a short description for the examples
| extent={{9,-9},{-9,9}}, | ||
| rotation=180, | ||
| origin={-81,41}))); | ||
| AixLib.Fluid.HeatExchangers.ConstantEffectiveness HeatExchanger( |
There was a problem hiding this comment.
start with lower case letters
| redeclare package Medium2 = WaterMedium, | ||
| m1_flow_nominal=poolParam.m_flow_out*1.5, | ||
| m2_flow_nominal=poolParam.m_flow_out, | ||
| dp1_nominal(displayUnit="bar") = 100000, |
There was a problem hiding this comment.
this pressure drop seems quite high to me
There was a problem hiding this comment.
Thanks for noticing, that was just a dummy... Changed it to 20kPa now!
|
@alexanderAKU: At some points I'm still not sure about the naming convention, e.g.the AixLib naming convention does not provide any information on the use of Booleans. In many AixLib models and also current IBPSA implementations for Boolean variables "use_" is used, therefore I decided on this approach, too. |
…ion reference files.Please pull the new files before push again. Plottet Results https://ebc.pages.rwth-aachen.de/EBC_all/github_ci/AixLib/1407-add-swimming-pool-model/plots/
|
@alexanderAKU I have added a new Icon for the pool package, so the model is ready to be merged in my optinion. Could you approve this once again? Thanks! |
This merge request adds a pool model incl. water treatment circuit into the fluid package as described in #1407:
--> AixLib.Fluid.Pool
This also includes a baseRecord and two corresponding records for a sports and a children's pool. Furthermore, there are records for pool walls so that different layers can be easily parameterized.
--> AixLib.DataBase.Pools
There are also two examples showing the usage with and without ideal heating.
--> AixLib.Fluid.Pool.Examples