Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo and remove experiment setup as the model is partial #1428

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

FWuellhorst
Copy link
Contributor

Closes #1427.

Besides the issue itself, I removed the experiment setup as this leads to an error in OM CI (all models with experiments are checked). Such a partial case should not contain the setup anyways.

@FWuellhorst FWuellhorst linked an issue Feb 17, 2023 that may be closed by this pull request
@FWuellhorst FWuellhorst added the good-first-review This review is a good entry point for new reviewers label Feb 17, 2023
@FWuellhorst FWuellhorst self-assigned this Feb 17, 2023
Copy link

@MZuschlag MZuschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accepted

@FWuellhorst
Copy link
Contributor Author

CI ran, I don't know why it does not show in here

@FWuellhorst FWuellhorst merged commit e07c9f8 into development Feb 17, 2023
@FWuellhorst FWuellhorst deleted the 1427-typo-in-class-name-in-choice branch February 17, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-review This review is a good entry point for new reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in class name in choice
2 participants