-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1505 rom initial conditions #1506
Conversation
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
@Jun-Jiang-92 Now that you know the PR workflow, do you want to do this review for me? |
…WTH-EBC/AixLib into issue1505_romInitialConditions
@FWuellhorst Thank you for the improvement. In addition to the in-line review, I have a few questions:
|
AixLib/ThermalZones/ReducedOrder/ThermalZone/BaseClasses/PartialThermalZone.mo
Show resolved
Hide resolved
@Jun-Jiang-92 Thanks for your review! Regarding full path, I changed occurrences. Regarding the parameter, a replaceable class may still be a parameter to indicate it is not a model. For records, it is usual to declare it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation. The changes can be merged after CI-check.
This closes #1505 but builds upon #1500 and should be merged after that one.
Once merged, we have to create the same issue in TEASER and remove all usages of
der_T(fixed=True)
- should be easy and fast.