-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibpsa merge custom errors #1517
Conversation
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
…ominal manually in examples
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /IBPSA_MergeCustomErrors/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
…ion reference files. Please pull the new files before push again. Plottet Results /IBPSA_MergeCustomErrors/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
1 similar comment
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
@martinkremer |
…iency in mover models
…/AixLib into IBPSA_MergeCustomErrors
…ion reference files. Please pull the new files before push again. Plottet Results /IBPSA_MergeCustomErrors/charts/
…/AixLib into IBPSA_MergeCustomErrors
… radau leads to failed simulation on linux (maybe due to older dymola version in CI)
…ion reference files. Please pull the new files before push again. Plottet Results /IBPSA_MergeCustomErrors/charts/
Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/AixLib/IBPSA_MergeCustomErrors/charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KremerMartin @larissakuehn @TobiasSpratte
Can someone of you have a quick look or just approve this PR? The CI passes, and I explained all changes below. I left the base branch not main to see what I changed aside from the +1000 new files in the actual merge of IBPSA.
This PR fixes errors and introduces changes based on the latest IBPSA merge.
- Either delete deleted in IBPSA or move to obsolete
- rename models to allow regression tests
- fix missing PumpHeadControlled
- Adjust IndoorSwimmingPool mover model, already discussed with @larissakuehn. Changes in regression results approved
- Change solver in simulate and plot scripts of ROM models to CVode, as in TEASER and because equippedExamples lead to stalled simulations in CI with Radau.
- Update NRPM models in Systems as nrpm is deprectated. As the default efficiency calculation in IBPSA was changed to Euler (with lower efficiencies), update GenericAHU example and results (only slight deviations) as approved by @KremerMartin
- Update version to 2.0.0 as Mover changes are not fully backwards compatible and the HeatPump model will move to obsolete at the hackday tomorrow, now that the new HP model is finally in AixLib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @FWuellhorst for your effort. Looks fine. :)
fix errors which are due to moved files or changed model behaviour.