-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved the connector from AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoomParams to .PartialRoom #1522
Moved the connector from AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoomParams to .PartialRoom #1522
Conversation
…BaseClasses.PartialRoomParams, because it should only contain parameters, and added the connector to AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoom
This closes #1401. |
Thank you for making a Pull Request to AixLib! Our CI pipeline will help you finalize your contribution.
If HTML errors occur, I will fix the issues using a separate pull request. Tips to fix possible naming violations:
If all CI stages pass and you have addressed possible naming violations, please consider the following:
Once you have addressed these points, you can assign a reviewer. If you have any questions or issues, please tag a library developer. |
…sing due to removing from PartialRoomParams
…tps://github.com/RWTH-EBC/AixLib into 1401-improve-parameterization-in-highorder-model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Removed the connector from AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoomParams, because it should only contain parameters, and added the connector to AixLib.ThermalZones.HighOrder.Rooms.BaseClasses.PartialRoom.