Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with nightly compiler #20

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Fix build with nightly compiler #20

merged 3 commits into from
Jul 24, 2020

Conversation

lperlaki
Copy link
Contributor

depends on: avr-device/27

@lperlaki lperlaki changed the title Changes needed to build with cargo nightly Changes needed to build with nightly Jul 24, 2020
@lperlaki
Copy link
Contributor Author

This patch enables this libary to be build with cargo build -Z build-std=core --target <avr-target> on nightly-2020-07-24

@lperlaki lperlaki mentioned this pull request Jul 24, 2020
Closed
Rahix
Rahix requested changes Jul 24, 2020
View reviewed changes
Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, apart from that everything looks good. Thanks!

avr-hal-generic/src/lib.rs Outdated Show resolved Hide resolved
@Rahix Rahix changed the title Changes needed to build with nightly Fix build with nightly compiler Jul 24, 2020
@Rahix Rahix merged commit 3cd813e into Rahix:master Jul 24, 2020
@Rahix
Copy link
Owner

Rahix commented Jul 24, 2020

Merged, thanks!

@lperlaki lperlaki deleted the nighly-build branch July 24, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahix Rahix Rahix requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lperlaki @Rahix