Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirection problem on about page #577

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

SohanRC
Copy link
Contributor

@SohanRC SohanRC commented Feb 16, 2024

Fixes Issue🛠️

Closes #458

Description👨‍💻

Previously when we were on the about page and we click the about option again on the nav bar, the whole page reloaded. It is resolved now !

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

Tested on local system and it worked fine !

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I am an Open Source Contributor

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 2666041
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65cf0efb365a8400082a4aad
😎 Deploy Preview https://deploy-preview-577--beautiify.netlify.app/assets/html_files/about
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SohanRC, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

Pls attach the demo video in the PR description @SohanRC

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 16, 2024
@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 16, 2024

Pls attach the demo video in the PR description @SohanRC

beautiify-about-google-chrome-2024-02-16-20-02-58_QwIhYuqO.mp4

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 16, 2024

@Rakesh9100 Please review now !

@Rakesh9100
Copy link
Owner

Merged 🎉 @SohanRC

@Rakesh9100 Rakesh9100 changed the title Redirection problem on about page Fixed redirection problem on about page Feb 17, 2024
@Rakesh9100 Rakesh9100 merged commit 8d56fd7 into Rakesh9100:main Feb 17, 2024
5 checks passed
@Rakesh9100 Rakesh9100 added Easy Low effort straightforward task Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC Open Source Program and removed question 🤔 Further information is requested labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task JWOC JWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Redirection problem on about page
2 participants