Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federated GCN for Chest X-ray screening #4

Merged
merged 37 commits into from
Feb 23, 2023
Merged

Federated GCN for Chest X-ray screening #4

merged 37 commits into from
Feb 23, 2023

Conversation

Kasliwal17
Copy link

No description provided.

Copy link
Owner

@Rakshith2597 Rakshith2597 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commented changes need to be made. Also, add a screenshot of the unit test out and pylint score for the folder as comments in the PR.

@Rakshith2597 Rakshith2597 changed the title Add files via upload Federated GCN for Chest X-ray screening Feb 16, 2023
@Kasliwal17
Copy link
Author

IMG-20230221-WA0002
IMG-20230221-WA0001
IMG-20230221-WA0000
Here the two error in testing export are due to issue with converting gnn modules to onnx

Copy link
Owner

@Rakshith2597 Rakshith2597 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the following?

  • Break up train utils into 2 files. One for with GNN and another for without GNN.
  • Update model weight and sample dataset links.
  • Check pylint score. Details provided in the google doc task 11.
  • Remove export unit tests for model with gnn.



#Main function for training
def trainer_with_GNN(lr, b_sz, img_pth, split_npz, train_transform, test_transform,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be resolved.

Kasliwal17 and others added 2 commits February 21, 2023 15:05
@Kasliwal17
Copy link
Author

I removed test export for gnn. Should i do the same with test_inference for gnn.

@Rakshith2597
Copy link
Owner

I removed test export for gnn. Should i do the same with test_inference for gnn.

You can remove inference using onnx and IR for GNNs.

@Kasliwal17
Copy link
Author

IMG-20230221-WA0008

@Rakshith2597 Rakshith2597 merged commit f530e50 into Rakshith2597:bmi8_new Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants