-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federated GCN for Chest X-ray screening #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commented changes need to be made. Also, add a screenshot of the unit test out and pylint score for the folder as comments in the PR.
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/README.md
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/README.md
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/README.md
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/README.md
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/README.md
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/transformations.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/test/test_export.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/test/test_export.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/test/test_inference.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/test/test_train.py
Outdated
Show resolved
Hide resolved
…est_export.py Co-authored-by: Rakshith Sathish <[email protected]>
…est_inference.py Co-authored-by: Rakshith Sathish <[email protected]>
…est_train.py Co-authored-by: Rakshith Sathish <[email protected]>
Updating the directory
Updating loss function to take weights from json file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you resolve the following?
- Break up train utils into 2 files. One for with GNN and another for without GNN.
- Update model weight and sample dataset links.
- Check pylint score. Details provided in the google doc task 11.
- Remove export unit tests for model with gnn.
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/inference_utils.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/model.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/model.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/train_utils.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/train_utils.py
Outdated
Show resolved
Hide resolved
misc/pytorch_toolkit/chest_xray_screening_federated_gcn/src/utils/train_utils.py
Outdated
Show resolved
Hide resolved
|
||
|
||
#Main function for training | ||
def trainer_with_GNN(lr, b_sz, img_pth, split_npz, train_transform, test_transform, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be resolved.
…ils/inference_utils.py Co-authored-by: Rakshith Sathish <[email protected]>
…ils/model.py Co-authored-by: Rakshith Sathish <[email protected]>
…ils/model.py Co-authored-by: Rakshith Sathish <[email protected]>
…ils/train_utils.py Co-authored-by: Rakshith Sathish <[email protected]>
…ils/train_utils.py Co-authored-by: Rakshith Sathish <[email protected]>
…ils/train_utils.py Co-authored-by: Rakshith Sathish <[email protected]>
I removed test export for gnn. Should i do the same with test_inference for gnn. |
You can remove inference using onnx and IR for GNNs. |
No description provided.