Skip to content

Commit

Permalink
Auto merge of #109935 - michaelwoerister:fix-feed-in-eval-always, r=c…
Browse files Browse the repository at this point in the history
…jgillot

incr.comp.: Make sure dependencies are recorded when feeding queries during eval-always queries.

This PR makes sure we don't drop dependency edges when feeding queries during an eval-always query.

Background: During eval-always queries, no dependencies are recorded because the system knows to unconditionally re-evaluate them regardless of any actual dependencies. This works fine for these queries themselves but leads to a problem when feeding other queries: When queries are fed, we set up their dependency edges by copying the current set of dependencies of the feeding query. But because this set is empty for eval-always queries, we record no edges at all -- which has the effect that the fed query instances always look "green" to the system, although they should always be "red".

The fix is to explicitly add a dependency on the artificial "always red" dep-node when feeding during eval-always queries.

Fixes rust-lang/rust#108481
Maybe also fixes issue rust-lang/rust#88488.

cc `@jyn514`

r? `@cjgillot` or `@oli-obk`
  • Loading branch information
bors committed Apr 12, 2023
2 parents 5e89fe4 + a8950cf commit 9881d01
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9881d01

Please sign in to comment.