Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniware+Pinecil: fix number of items in uVtoDegC array. This only af… #1531

Merged

Conversation

purdeaandrei
Copy link
Contributor

…fects us in case we go above 500degC, in which case we'll be reading invalid memory

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

Bugfix. Interpolator will think that there are twice as many elements in lookup table. Not very likely unless temperature goes above the max in the table, in which case we'll be accessing invalid memory.
image

  • What is the current behavior?
  • What is the new behavior (if this is a feature change)?

  • Other information:

…fects us in case we go above 500degC, in which case we'll be reading invalid memory
@Ralim Ralim merged commit b96dbb2 into Ralim:dev Jan 16, 2023
@Ralim Ralim added this to the 2.21 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants