Added VPDO option for disabling PPS/EPR PDOs. #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have tried compiling with all languages first before creating this PR... |
|
I'm all for this idea. Also note you will need to also add a new entry to to extend it to being exposed over BLE.But once build passes; looks fine by me otherwise. |
|
Hmm, dont think those TS80P build failures may be your fault; if you dont have time to debug them I'll look into them later on |
TS80P build failed Github checks.
|
Oh - Looks like I forgot to actually create the BLE characteristic. |
|
Okay - that should do it. |
|
This should be ready to merge provided everything looks good. |
Samuelrmlink
added a commit
to Samuelrmlink/IronOS
that referenced
this pull request
Feb 20, 2023
Merge pull request Ralim#1582 from Samuelrmlink/PPSctrl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "PD VPDO Enabled" option to the Power settings menu.
This option allows the user to disable PPS/EPR PDOs and just use the best Fixed PDO available.
Pinecil chooses whatever appears to be the best PDO available.
(Maximum power without overloading the supply)
What is the new behavior (if this is a feature change)?
Behavior remains the same - unless the "PD VPDO Enabled" option is unticked in the Power settings.
Other information: