Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Launch Data Preview data url textbox to data.view toolbar #61

Closed
RandomFractals opened this issue Jun 22, 2019 · 1 comment
Closed

add Launch Data Preview data url textbox to data.view toolbar #61

RandomFractals opened this issue Jun 22, 2019 · 1 comment
Labels
enhancement New feature or request UX User Experience enhancement

Comments

@RandomFractals
Copy link
Owner

RandomFractals commented Jun 22, 2019 •
edited
Loading

related to #15 for online public data sources preview

implementation notes/script:

  • move all fs.readFileSync(dataFilePath) calls for local file reads to new /utils/file-utils.ts
  • use https://github.com/d3/d3-fetch for loading public data sources data if data.url starts with http: or https:
  • use fs.readFileSync(dataFilePath) as before for local data file reads or files with full file:/// schema URI's
  • use vscode.workspace.findFiles() API to load relative local data files
@RandomFractals RandomFractals added enhancement New feature or request UX User Experience enhancement labels Jun 22, 2019
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 added new file.utils.ts for local and remote data reads
d7c8fcb
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 switched to using new file.utils.ts for reading local text and bi…
f7f1927 
…nary data files

+ data.preview methods reorg
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 moved createJsonFille() to new file.utils.ts
aa1732a
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 added quick and dirty data.url input UI setup
5f6a627
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 wired data.url input to new loadDataPreviewForUrl() and loadView …
eedc81d 
…data.preview command calls
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 added workspace view/data files loading
8fed6e3
RandomFractals added a commit that referenced this issue Jun 23, 2019
@RandomFractals
#61 changed data.url input tooltip to enter data path for now
6ab9029 
to release workspace data files loading
RandomFractals added a commit that referenced this issue Jun 24, 2019
@RandomFractals
#61 v. bump for new remote data support v1.20 release
fefbbde
RandomFractals added a commit that referenced this issue Jun 24, 2019
@RandomFractals
#61 fixed new data-url-input size and toolbar wrapping for data.previ…
4dfd781 
…ew on side
RandomFractals added a commit that referenced this issue Jun 24, 2019
@RandomFractals
#61 kludgy fix for toolbar right nowrap css for now
e86c1dc 
to keep new data-url-input text box in line for all view panel sizes
RandomFractals added a commit that referenced this issue Jun 24, 2019
@RandomFractals
#61 added toolbar-right left padding and bg color for narrow view siz…
0f222f0 
…e and left/right toolbars overlap
RandomFractals added a commit that referenced this issue Jun 24, 2019
@RandomFractals
#61 added Quick Launch workspace data files bit to docs
47aa08c
@RandomFractals
Copy link
Owner Author

closing this. will create new ticket for remote data support

@RandomFractals RandomFractals mentioned this issue Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request UX User Experience enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RandomFractals