Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for embed flags and update attachment flags #10085

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add support for embed flags and update attachment flags #10085

wants to merge 4 commits into from
+108 −1

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Jan 22, 2025 •
edited
Loading

Summary

  • Adds EmbedFlags and EmbedMediaFlags.
  • New flags parameter on Embed.__init__ and Embed.set_image.
  • New flags type hint on _EmbedImageProxy protocol.
  • New flags on AttachmentFlags

DDevs PR: discord/discord-api-docs#7353

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

dolfies
dolfies reviewed Jan 23, 2025
View reviewed changes
discord/embeds.py Outdated Show resolved Hide resolved
dolfies
dolfies reviewed Jan 23, 2025
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfies dolfies dolfies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DA-344 @dolfies