Add lua manager support (normal + API) #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's ready for review Edit: nvm lmao |
Coolsonickirby
changed the title
|
Tested a handful of in-game menus + played through a couple 10-stock all items high matches with functions registered on both, the menu and in-game managers and haven't ran into any issues |
|
Pushing onto the lua stack for
has been added. Now rust functions can return values for the lua script to use. |
|
Tested and Ready! |
Raytwo
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code that allows ARCrop to register managers for the lua scripts and also expands the API to allow other plugin makers to register their own lua managers.
This PR isn't fully ready yet, as it still needs to be reviewed and also misses the signatures for the new functions.