Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra ` to balance chunk delimiters #343

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Remove the extra ` to balance chunk delimiters #343

merged 1 commit into from
Oct 15, 2021

Conversation

yihui
Copy link
Contributor

@yihui yihui commented Oct 15, 2021

FYI unbalanced chunk delimiters will no longer be allowed in the future (yihui/knitr#2057). Thanks!

Unbalanced chunk delimiters will no longer be allowed in the future (yihui/knitr#2057).
@eddelbuettel
Copy link
Member

eddelbuettel commented Oct 15, 2021

Thanks. It's both an (obvious) typo and an relic from a time (Aug 2015 or six years ago) when I still wrote things that way; these days I just rely mostly on just pandoc and only need the rmarkdown/knitr/... machinery for access to it. I'll clean the vignette up that way in a follow-up commit.

@eddelbuettel eddelbuettel merged commit 6645174 into Rblp:master Oct 15, 2021
@yihui
Copy link
Contributor Author

yihui commented Oct 15, 2021

Great! Thanks again!

@yihui yihui deleted the patch-1 branch October 15, 2021 14:05
@eddelbuettel
Copy link
Member

Thanks for catching it, and yep, it is likely the right move to bail on bad syntax.

Follow-up commit made in 4548139 which also adds the ChangeLog entry for your change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants