use litedown for rendering vignettes #6583
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6583 +/- ##
=======================================
Coverage 98.60% 98.60%
=======================================
Files 79 79
Lines 14516 14516
=======================================
Hits 14314 14314
Misses 202 202 ☔ View full report in Codecov by Sentry. |
|
This PR is on hold until current GH version of |
|
Earmark: after #6589, if {knitr} is not in |
|
NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67 |
There was a problem hiding this comment.
NB: After #6618, we'll also want to check this issue whether it should be included, or left as a TODO: yihui/litedown#67
It's safe to use litedown:::.env$input with the current CRAN version of litedown. The next CRAN release should take place in a few weeks, and you'll be able to use litedown::get_input().
| opts = litedown::reactor() | ||
| opts$comment = "# " | ||
| opts$error = FALSE | ||
| opts$print = function(x, ...) capture.output(if (isS4(x)) methods::show(x, ...) else print(x, ...)) |
There was a problem hiding this comment.
error = FALSE will suppress errors in litedown, which is probably not what you want. I think you wanted the default error = NA instead, so there is no need to set it.
print = NA tells litedown to use R's default print function.
| opts = litedown::reactor() | |
| opts$comment = "# " | |
| opts$error = FALSE | |
| opts$print = function(x, ...) capture.output(if (isS4(x)) methods::show(x, ...) else print(x, ...)) | |
| litedown::reactor(comment = "# ", print = NA) |
Closes #6394