-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carthage build error #44
Conversation
@mjarvis @dani-mp Can you have a look on your local machines? 🤔
I have the same problem when I open the ReSwift-Thunk Xcode project and try to build for Mac. iOS works fine, but Mac complains:
I wonder if that's an Xcode bug or misconfiguration on our part. |
Also no dice with Xcode 11.6 beta |
import XCTest | ||
@testable import ReSwift_Thunk_tvOS | ||
|
||
class ReSwift_Thunk_tvOSTests: XCTestCase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type Name Violation: Type name should only contain alphanumeric characters: 'ReSwift_Thunk_tvOSTests' (type_name)
ee774e5
to
72b419f
Compare
@DivineDominion CI should pass this time around, if you want to take a look at my updates before I merge and then release I've tested this with |
@mjarvis LGTM! Also, sorry I was too late with ReSwift yesterday and you had to figure out the carthage.sh stuff for yourself all over again. |
Accidentally included in #44
I upgraded my machine to Catalina, Xcode to 11.5, and Carthage to 0.35.0 -- and now
ReSwift-Thunk
doesn't compile anymore because it doesn't find the proper ReSwift :)(Let's see what CI says)