fix(YouTube - SponsorBlock): Skip segments when casting #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand to fix skipping while casted to a TV
oSumAtrIX
changed the title
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/app/revanced/patches/youtube/video/information/fingerprints/MdxSeekFingerprint.kt
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
.../app/revanced/patches/youtube/video/information/fingerprints/MdxPlayerDirectorFingerprint.kt
Outdated
Show resolved
Hide resolved
fix(YouTube - SponsorBlock): Skip segments when casting ReVanced#3331
3 tasks
oSumAtrIX
requested changes
Jun 27, 2024
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/app/revanced/patches/youtube/video/information/fingerprints/MdxSeekFingerprint.kt
Show resolved
Hide resolved
.../app/revanced/patches/youtube/video/information/fingerprints/MdxPlayerDirectorFingerprint.kt
Outdated
Show resolved
Hide resolved
…/VideoInformationPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
…/VideoInformationPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
LisoUseInAIKyrios
approved these changes
Jul 3, 2024
|
@thedroidgeek Please verify skipping while casting still works after these refactors (I don't have any devices to try) |
|
Sorry for the inactivity. @LisoUseInAIKyrios I just tested and everything seems to work properly with these changes. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
This seems ready to go |
oSumAtrIX
reviewed
Jul 10, 2024
src/main/kotlin/app/revanced/patches/youtube/video/information/VideoInformationPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Jul 10, 2024
...ain/kotlin/app/revanced/patches/youtube/video/information/fingerprints/MdxSeekFingerprint.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
approved these changes
Jul 10, 2024
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
revanced-bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
# [4.11.0](v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([#3379](#3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([#3402](#3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([#3397](#3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([#3365](#3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([#3415](#3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([#3331](#3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([#3334](#3334)) ([9414122](9414122)) * Add translations ([#2963](#2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([#3366](#3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([#3380](#3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](#3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([#3386](#3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([#3359](#3359)) ([fbd0507](fbd0507))
E85Addict
pushed a commit
to E85Addict/revanced-patches
that referenced
this pull request
Jul 11, 2024
# [4.11.0](v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([ReVanced#3379](https://github.com/E85Addict/revanced-patches/issues/3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([ReVanced#3402](https://github.com/E85Addict/revanced-patches/issues/3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([ReVanced#3397](https://github.com/E85Addict/revanced-patches/issues/3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([ReVanced#3365](https://github.com/E85Addict/revanced-patches/issues/3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([ReVanced#3415](https://github.com/E85Addict/revanced-patches/issues/3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([ReVanced#3331](https://github.com/E85Addict/revanced-patches/issues/3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([ReVanced#3334](https://github.com/E85Addict/revanced-patches/issues/3334)) ([9414122](9414122)) * Add translations ([ReVanced#2963](https://github.com/E85Addict/revanced-patches/issues/2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([ReVanced#3366](https://github.com/E85Addict/revanced-patches/issues/3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([ReVanced#3380](https://github.com/E85Addict/revanced-patches/issues/3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([ReVanced#3321](https://github.com/E85Addict/revanced-patches/issues/3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([ReVanced#3386](https://github.com/E85Addict/revanced-patches/issues/3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](https://github.com/E85Addict/revanced-patches/issues/3359)) ([fbd0507](fbd0507)) ### Performance Improvements * Personal Logo && Add upstream sync ([0d56aa1](0d56aa1))
E85Addict
pushed a commit
to E85Addict/revanced-patches
that referenced
this pull request
Jul 12, 2024
# [4.11.0](v4.10.0...v4.11.0) (2024-07-12) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([ReVanced#3379](https://github.com/E85Addict/revanced-patches/issues/3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([ReVanced#3402](https://github.com/E85Addict/revanced-patches/issues/3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([ReVanced#3397](https://github.com/E85Addict/revanced-patches/issues/3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([ReVanced#3365](https://github.com/E85Addict/revanced-patches/issues/3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([ReVanced#3415](https://github.com/E85Addict/revanced-patches/issues/3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([ReVanced#3331](https://github.com/E85Addict/revanced-patches/issues/3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([ReVanced#3334](https://github.com/E85Addict/revanced-patches/issues/3334)) ([9414122](9414122)) * Add translations ([ReVanced#2963](https://github.com/E85Addict/revanced-patches/issues/2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([ReVanced#3366](https://github.com/E85Addict/revanced-patches/issues/3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([ReVanced#3380](https://github.com/E85Addict/revanced-patches/issues/3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([ReVanced#3321](https://github.com/E85Addict/revanced-patches/issues/3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([ReVanced#3386](https://github.com/E85Addict/revanced-patches/issues/3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](https://github.com/E85Addict/revanced-patches/issues/3359)) ([fbd0507](fbd0507)) ### Performance Improvements * Personal Logo && Add upstream sync ([6ded142](6ded142))
|
It works only on root version? |
|
No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add patch code to support skipping segments while casted to a big screen device, by hooking the MDX director class to intercept object instances in order to be able to call the seekTo method, similar to how it's done in the 'regular' player class.
Fixes #374.
Integrations PR: ReVanced/revanced-integrations#655