-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nullable Bindings #57
add nullable Bindings #57
Conversation
…nmask null values in an Optional<T> or guarded by a sentinel
value = unmaskingFunction.apply(t); | ||
fireValueChangedEvent(); | ||
} catch (Exception e) { | ||
onError(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if passing the exception to onError is the right approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me, BindingObserver.onError(throwable)
apply user error management if provided or the exception is ignored.
I don't see the point of this PR, maybe I don't understand very well what you want to achieve. I think the main idea behind |
Hi @rguillens, |
Now I understand your PR and the code looks very good. Congrats... |
Hi @protogenes, thank you for contributing this. I'm speaking to KotlinConf this week so I may not be able to follow up until afterwards. I will take a look at this and merge then. |
Hi @thomasnield how was KotlinConf? |
@protogenes It was amazing, thank you. The talk will be uploaded to YouTube by JetBrains in the next week or two. The slides for my presentation are here: https://github.com/thomasnield/kotlinconf-datascience-talk Regarding this PR, I'll try to take a look tonight alongside some PR's for RxKotlin. |
I was just about to argue with this, but as I tried to write my alternative solution I get it now. I'll merge tomorrow after I review this with fresh eyes. |
Good work, sorry it took me so long to get to this. It's been a busy year. |
I'll do a release for RxJavaFX and RxKotlinFX. |
add overloads to JavaFxObserver and JavaFxSubscriber which allow to unmask null values in an Optional or guarded by a sentinel as counterpart to JavaFxObservable.nullableValuesOf