refactor(operator): operators should call source.subscribe #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| import {Subscriber} from './Subscriber'; | |||
|
|
|||
| export class Operator<T, R> { | |||
| call(subscriber: Subscriber<R>): Subscriber<T> { | |||
| return new Subscriber<T>(subscriber); | |||
| call(subscriber: Subscriber<R>, source: any): any { | |||
There was a problem hiding this comment.
Is it possible to limit type of source instead of any?
|
Looks like what we discussed. LGTM. |
|
Weird, how is this PR still open? |
|
I think it's just not closed. Let me close it. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Passing the source into the operator lets the operator determine when the source subscription occurs (if at all). This will allow us to fix subscription ordering bugs like #1360.
Related issue (if exists):
#1360 is the only one that's filed as far as I know, but there are most likely others (
finallycomes to mind).cc: @Blesh