Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify dtslint tooling #4791

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented May 17, 2019

Description:

The PR that I opened to have the localTs path resolved has been merged and a new version of dtslint has been published, so there is no longer a need to pass an absolute path via the command line.

This PR removes that script that was used to pass an absolute path to the local TypeScript install and passes a relative path, instead.

Related issue (if exists): None

@benlesh
Copy link
Member

benlesh commented Jun 4, 2019

@cartant Looks like we just need the conflict resolved and this is good to go.

@cartant cartant force-pushed the simplify-dtslint-tooling branch from c306acd to 36f0649 Compare June 5, 2019 01:14
@cartant
Copy link
Collaborator Author

cartant commented Jun 5, 2019

@benlesh Conflicts in this should be resolved. I've not resolved those in #4790 because - AFAICT - it will conflict with the changes in this PR. I'll resolve #4790 after this PR is merged.

@benlesh benlesh merged commit 1cb27a4 into ReactiveX:master Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 6, 2019
@cartant cartant deleted the simplify-dtslint-tooling branch September 24, 2020 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants