WIP #1
Open
WIP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njoyce
force-pushed
the
random-refactorings
branch
4 times, most recently
from
4a6d98b to
461f549
Compare
|
docstrings plz |
tylertreat
approved these changes
Mar 7, 2019
|
|
||
|
|
||
| @charm.configure | ||
| def configure_workload(): |
There was a problem hiding this comment.
Did you deliberately remove the charm status stuff? E.g. the existing charm code has stuff like:
layer.status.maintenance('starting workload')IMO it's nice to be able to pipe messages out to the juju client.
There was a problem hiding this comment.
Yea - they seemed like standard messages that the framework/library should be providing.
There was a problem hiding this comment.
Gotcha, yes I agree they should just have built-in ones for these hooks.
|
|
||
| workload.set_oci_image(charm.resources['mariadb']) | ||
| workload.open_port('db', containerPort=3306, protocol='TCP') | ||
| workload.env.set('MYSQL_ROOT_PASSWORD', root_password) |
There was a problem hiding this comment.
Is this mapping to a podspec?
There was a problem hiding this comment.
yep, and potentially a configuration to run it in the machine world too
njoyce
force-pushed
the
random-refactorings
branch
2 times, most recently
from
422eaf2 to
15aef1e
Compare
|
Docstrings added. |
njoyce
force-pushed
the
random-refactorings
branch
from
15aef1e to
076b349
Compare
njoyce
force-pushed
the
random-refactorings
branch
from
076b349 to
3daabec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.