-
-
Notifications
You must be signed in to change notification settings - Fork 152
Conversation
const forceTouchAvailable = false; | ||
|
||
const statics = { | ||
AccessibilityComponentType: AccessibilityComponentTypes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use the property shorthand here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a plurality difference here unfortunately. I made the decision to follow the pattern in react-native
(https://github.com/facebook/react-native/blob/master/Libraries/Components/View/ViewAccessibility.js#L59-L64). However, I'm not super insightful about this property in statics
, so I'm open to ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah -- missed that. Makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks like there's some issues in the tests on node 4, but these seem to do with dependancy issues outside this PR, so i'm happy to merge as-is.
Hi guys, I tried
but it must be wrong because I get this issue after:
Thanks! |
@jcharlet if I understand correctly you shouldn't be Try it again without deleting the |
@newtonry great thanks! I had conflicts between react-native module of my project and react-native-mock (they use different versions). so I simply removed react-native from react-native-mock/node_modules (but still kept the rest) and it now works :) ! |
I am running into issues with this PR as well. After running: Then Looks like the
but there is no
|
@gardner same problem here, did you find a solution for this? |
@gardner @lucascarvalho You need to build
|
Due to the deprecation of
View.propTypes
, we are now supposed to useViewPropTypes
imported fromreact-native
. This library doesn't support that yet, so this PR addsViewPropTypes
. It should resolve issues like #139 and #132. In it, I've:propTypes
from being defined inView.js
ViewPropTypes
which matches https://github.com/facebook/react-native/blob/master/Libraries/Components/View/ViewPropTypes.js minusTVViewPropTypes
AccessibilityTraits
andAccessibilityComponentTypes
to aViewAccessibility
file. Let me know if this should go somewhere else.ViewPropTypes