-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decisions section to onboarding docs. #4
base: master
Are you sure you want to change the base?
Conversation
|
||
## Decisions | ||
|
||
All decisions that have been made are captured in the [decision log](./Decisions.md). Please check there for questions that have already been raised an answered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and* answered
|
||
### What, if anything, should we do to safeguard the public-facing data on this site? | ||
|
||
The data on this site was public to begin with. Scraped from other public sites, or given to us to use publicly with consent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sentence fragment. Suggestion:
"We compiled public data. and we were given data with consent for public use."
Something like that? We can mention scraping if we want. IANAL, but I don't think it's that important to clarify scraping vs manual curation. (I'm also attempting to stay away from a passive voice, though that's less crucial.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, not going to stop the merge but I think there are a few decisions missing, happy to add them in once this is merged in a seperate PR.
Main ones I can think of are:
What fields are we scraping? ( Though maybe that needs adding to the main page/technical requirements document?)
How are we dealing with duplicate data?
How are we handling image uploads?
Which business categories are there, what if what I am scraping looks very different?
Great discussions unfolded today that lead to several key decisions being made. It's important for everyone to have access to these questions and their outcomes, but it's difficult to piece them together across the various conversations. So, I added them to the onboarding docs for convenience.